[jaeger] define securityContext for each resources #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
eumel8
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
pavelnikolov
requested changes
Dec 20, 2023
| @@ -613,14 +639,6 @@ query: | |||
| pathType: | |||
| health: | |||
| exposed: false | |||
| resources: | |||
There was a problem hiding this comment.
Why did you remove the resources for the ingress?
There was a problem hiding this comment.
you mean for query, ingress has no resources. I think this was a mistake and almost twice. It was a bit confusing to walk all the values over the time. If it would make sense to have this in alphabetically order? Then I would do this on another PR
There was a problem hiding this comment.
Sorry for the late response on this, I'd prefer refactoring in another PR.
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
|
@pavelnikolov no problem. Everyone complains the lack of open source contribution and then it takes months to review a PR. I had this very often and I ask me: What's wrong with my PR's. |
|
I'm sorry for closing it. |
5 tasks
Signed-off-by: Pavel Nikolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
At least and especially for the all-in-one installation securityContext was missing which brings a bad experienance if you start with Jaeger. This PR
Which issue this PR fixes
Checklist
[jaeger]or[jaeger-operator])