This repository has been archived by the owner on Nov 25, 2017. It is now read-only.
Update to Ch5 and Ch6 to more closely reflect user experiance #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image to reflect user experience and added in another image. Also updated figure references throughout the document.
|
@brendantcd wellcome to github. thanks for your contribution. i hope to merged these pull requests to my repository https://github.com/suhailvs/djangobook.com. |
suhailvs
added a commit
to suhailvs/djangobook.com
that referenced
this pull request
Jun 16, 2014
…acobian#75 + fix the field name restrictions layout + import error - "from mysite. books.models import Book" to "from books.models import Book" jacobian#75,jacobian#74 + The settings.py file has been purposefully simplified in recent versions of Django, So TEMPLATE_DIRS dictionary is now removed from settings.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Ch5, fixed views import.
changed
"from mysite. books.models import Book"
to
"from books.models import Publisher, Author, Book"
When using the original code i was being shown the Django error page with
"ImportError at /admin/
No module named books.models"
The issue have been documented on StackOverflow at http://stackoverflow.com/questions/15296126/importerror-no-module-named-books-models/16286000#16286000
Update to Ch6, updated an existing image (6-2) to reflect the user experience. admin_index.png showed links to the Books, Publishers and Authors panels when this could not have been possible if the user was following the instructions. This image has been updated.
A copy of 6-2 was inserted later in the document, as "figure 6-7" where it is reflective of the user experience.
All subsequent figure numbers in the document have been updated.
NOTE: This is my first ever contribution to an OpenSource project, and in fact my first ever fork and pull request on GitHub. I would appreciate any feedback.
Thanks
Brendan