Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change protocol name into ObjObsSAP #15

Closed
wants to merge 3 commits into from

Conversation

gmantele
Copy link

Following recent discussions about the name of this protocol, I took the liberty to rename this GitHub repository into ObjObsSAP (as well as its description). The former name ObjVisSAP should still work for Git operation (clone, pull, push, ...), but it is strongly recommended to change the URL of the remote repository in local clones with the following commands:

# 1. List all remote repository you have:
git remote -v

# 2. Find the one corresponding to `ivoa-std/ObjVisSAP` ; generally it is named `origin`

# 3. Update the URL of this remote repository:
git remote set-url origin [email protected]:ivoa-std/ObjObsSAP.git

Anyway, this PullRequest aims to propagate the name change inside the document itself and all related files. I tried to change this name (and its long form: Object Visibility into Object Observability) everywhere.

Please, make sure I did it well everywhere, especially in the examples where the URL of the (existing?) services included ObjVisSAP, as well as in the URI of the ObjObsSAP data model.

@gmantele gmantele added the enhancement New feature or request label Oct 10, 2024
@molinaro-m
Copy link
Member

Hi @gmantele : I find difficulties in building the doc, it seems to have something to do with the bibliography.

Besides that, the failure in autobuild is related to the version of upload-artifact (now @v4) and the preview I don't know (I have the same issue in ConeSearch)

Anyway, all the above is minor to me, while possibly I'd like to see a changelog for the doc name change, just for future reference. I would have suggested one in review but, without being able to compile first, I don't know where to start from.

@gmantele
Copy link
Author

It should now be OK for the CI.

Your issue with the Cone Search should be solved the same way I did (the properties tag-name and tag-description should be put in lower case now with v2 of weareyipyip/walking-tag-action).

Anyway, I am not sure about the change log. It is the first version of this protocol and it is still a draft. I don't know if having a change log just for this name change is very useful :-/ If you want one anyway, I can add that. Do you have a suggestion?

@molinaro-m
Copy link
Member

now, fine as it is...I have to fix something on my side, because I cannot make the doc on my machine, it errors out with

[15] (./ObjObsSAP.bbl
Runaway argument?
\parindent \z@ \bibpreamble \bibfont \list {\@biblabel {\the \c@NAT@ctr \ETC.
! Paragraph ended before \HD@@guesstoclevel was complete.

@molinaro-m molinaro-m closed this Oct 10, 2024
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with name change

gmantele added a commit that referenced this pull request Nov 20, 2024
@gmantele gmantele mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants