Allows customization of icons #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes isteven#245 in original repository. After this change the user can fully customize the "icons", replacing the default html entity characters by any string, including: - Different html entities or unicode characters; - Bits of html offloading things to a icon font; - Html img tags; - Empty strings (that effectively removes the icons); The change is backwards compatible, only "activated" if the element that uses this directive also has a `custom-icon` attribute. That attribute works analogous to the `translation` attribute. Backwards compatability is the reason for the somewhat convoluted "pad-with-nbsp" function, that might be removed in a future major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245 in original repository.
After this change the user can fully customize the "icons", replacing
the default html entity characters by any string, including:
The change is backwards compatible, only "activated" if the element that
uses this directive also has a
custom-iconattribute. That attributeworks analogous to the
translationattribute. Backwards compatabilityis the reason for the somewhat convoluted "pad-with-nbsp" function, that
might be removed in a future major release.