Fix mistake about final
and override
not affecting final
classes; reword enforcement to be clearer
#2235
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mistake about
final
andoverride
not affectingfinal
classes; reword enforcement to be clearer.override
andfinal
onfinal
classesfinal
, it doesn't matter whether you putoverride
orfinal
on an individual virtual function.That is incorrect. The semantics change if
override
orfinal
is used on an individual virtual function. Correction:final
, individual virtual functions cannot be overridden whether or not you putfinal
on them. However, usingoverride
, orfinal
withoutvirtual
, on a member function of a class markedfinal
ensures that it overrides a base class virtual function.Better Wording
override
norfinal
.Better wording:
override
norfinal
.