Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade curl latest version #7021

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Kim-jy0819
Copy link

@Kim-jy0819 Kim-jy0819 commented Oct 22, 2024

Type

Motivation and Context

The release files are using older version(7.88.0), but this softwares have many vulnerabilities.
So I upgrade version to 8.10.1
image

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Hello this is �my first time opening a pull request in Open3D.
I'm not sure the right file is generated. Below is my command. Thank you.

docker run -it -v .:/app ubuntu:18.04
VERSION=8.10.1

apt-get update -y
apt-get install -y nghttp2 libnghttp2-dev libssl-dev build-essential wget
apt-get install libpsl-dev
wget https://curl.haxx.se/download/curl-${VERSION}.tar.gz
tar -xzvf curl-${VERSION}.tar.gz 
rm -f curl-${VERSION}.tar.gz
cd curl-${VERSION}
./configure --prefix=/usr/local --with-ssl --with-nghttp2
make -j4
make install
tar -cvf curl_8.10.1_linux_x86_64.tar.bz2 include lib

File
curl_8.10.1_linux_x86_64.tar.zip

reference

Copy link

update-docs bot commented Oct 22, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review November 6, 2024 15:40
@ssheorey ssheorey added this to the v0.19 milestone Nov 6, 2024
End hosting curl binaries to allow easy version updates.
@ssheorey
Copy link
Member

Hi @Kim-jy0819 thanks for submitting this PR. I fixed some undefined symbol errors on macOS. Also, we will no longer host curl binaries to make it easier to do version updates in the future.

Looks good - tested locally. We can merge once CI passes.

@Kim-jy0819
Copy link
Author

Hi @ssheorey,

Thank you for the review and approval! I really appreciate your work on resolving the undefined symbol errors on macOS and the advice on not hosting curl binaries.

Regarding the CI failures (e.g., on MacOS and Ubuntu), I’m currently looking into the logs, but I’m finding it challenging to pinpoint the exact cause. If you have any insights or suggestions on where I should focus my attention, that would be incredibly helpful.

I’ll continue investigating in the meantime and will keep you updated on my progress. Thank you again for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vuln for dependency] Please release new .whl files by using newest curl
2 participants