-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BUILD_DEBIAN_PACKAGE option for Debian package support #6982
base: main
Are you sure you want to change the base?
Conversation
Introduced the `BUILD_DEBIAN_PACKAGE` CMake option to enable building a Debian package for the library. When this option is enabled and the host system supports Debian, the library will be packaged accordingly. Usage: To enable debian package building: `cmake -DBUILD_DEBIAN_PACKAGE=ON <other_config_options> .. To build debian package: `make package` or `cpack` Signed-off-by: Meet Gandhi <[email protected]>
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Hi @meetgandhi-dev This is a really useful PR. Can you add this to the CI, so we can test the resulting deb package? You can add to the CI here. Essentially, just copy the steps we do for |
- Enabled `BUILD_DEBIAN_PACKAGE` to ensure Debian package creation if supported. - Previously, TXZ (.tar.xz) packaging was disabled, which could break dependent pipelines. Signed-off-by: Meet Gandhi <[email protected]>
Hello @ssheorey |
7c72d38
to
fc2903c
Compare
- Used the same name format for the Debian package to differentiate between different build options. - Added logic to copy the Debian package (if generated) to the root directory. - Updated CI pipeline to upload the generated Debian package as artifact. Signed-off-by: Meet Gandhi <[email protected]>
fc2903c
to
74abf04
Compare
Hi @meetgandhi-dev can you check the CI? The deb package was not created (The CI runs on Ubuntu 20.04). https://github.com/isl-org/Open3D/actions/runs/11086074701/job/30938149427?pr=6982#step:4:13576 |
Hello @ssheorey , |
Signed-off-by: Meet Gandhi <[email protected]>
HI @meetgandhi-dev thanks for the update. I can now locally build the deb package and install it. One issue with the deb package is
|
@ssheorey Thanks for the heads up! When we disable the |
Introduced the
BUILD_DEBIAN_PACKAGE
CMake option to enable building a Debian package for the library. When this option is enabled and the host system supports Debian, the library will be packaged accordingly.Usage:
To enable debian package building:
`cmake -DBUILD_DEBIAN_PACKAGE=ON <other_config_options> ..
To build debian package:
make package
or
cpack
Type
Motivation and Context
This feature simplifies installation by allowing users to generate a Debian package directly through CMake, adhering to standard packaging conventions and enabling seamless integration with package management tools like apt. By streamlining the development workflow, we empower developers to focus on feature enhancement while encouraging community contributions and customisation. Overall, this initiative broadens our library's reach and strengthens its position within the open-source ecosystem, making it more user-friendly and accessible.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Here is the summary of different outouts:
$ cmake -DBUILD_DEBIAN_PACKAGE=ON ..
configure.log
cpack
Install manifests:
install_manifest.txt