Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/footer #9

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Feat/footer #9

merged 6 commits into from
Sep 14, 2024

Conversation

Chulinuwu
Copy link
Collaborator

Type of Change

  • [Footer ] New features

Description

Webview / Mobileview footer

Screenshots or GIFs (if applicable)

image

image

image

@macgeargear
Copy link
Contributor

@punchanabu where should we store the svg files

@macgeargear
Copy link
Contributor

macgeargear commented Sep 13, 2024

LGTM💯 but wait @punchanabu to confirm where to place the SVG files

src/lib/components/Footer/suculogo.png Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.svelte Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.svelte Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.svelte Show resolved Hide resolved
src/lib/components/Footer/Footer.svelte Outdated Show resolved Hide resolved
Copy link
Member

@punchanabu punchanabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

แก้นิดเดียว

src/lib/components/Footer/Footer.svelte Outdated Show resolved Hide resolved
@macgeargear
Copy link
Contributor

ฝาก merge อีกรอบครับ พอดีพึ่ง merge branch ผมเข้า dev ไปตะกี๊ 🙇🏻‍♂️

@Chulinuwu Chulinuwu merged commit c74a910 into dev Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants