Increase strictness of global isel use for ROCM #19247
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase strictness while this is primarily for development instead of robust production cases (though it is still quite robust). This will prevent fallback from global-isel with unsupported inputs to prevent a situation of attributing a witnessed change to improved global isel results that are actually caused by not using global isel or to prevent a lack of change caused by not actually utilizing global isel. In this form, unsupported inputs will fail to compile entirely.
tpopp
force-pushed
the
users/tpopp/global-isel-caution
branch
from
10ad800
to
41967aa
Compare
kuhar
reviewed
Nov 21, 2024
| @@ -462,7 +462,12 @@ class ROCMTargetBackend final : public TargetBackend { | |||
| opt.UnsafeFPMath = false; | |||
| opt.NoInfsFPMath = false; | |||
| opt.NoNaNsFPMath = true; | |||
| // Be extra cautious while this is less tested, and prevent unknown | |||
| // fallbacks from global isel. | |||
There was a problem hiding this comment.
Could you briefly explain what this option does and how we can observe the difference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase strictness while this is primarily for development instead of robust production cases (though it is still quite robust).
This will prevent fallback from global-isel with unsupported inputs to prevent a situation of attributing a witnessed change to improved global isel results that are actually caused by not using global isel or to prevent a lack of change caused by not actually utilizing global isel.
In this form, unsupported inputs will fail to compile entirely.