Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and samples to use latest iree-turbine. #19054

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Nov 6, 2024

This adapts docs and samples to https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0.

@ScottTodd ScottTodd added documentation ✏️ Improvements or additions to documentation infrastructure Relating to build systems, CI, or testing integrations/pytorch PyTorch integration work labels Nov 6, 2024
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Scott, this is a great improvement!

samples/colab/pytorch_aot_advanced.ipynb Show resolved Hide resolved
samples/colab/pytorch_aot_simple.ipynb Show resolved Hide resolved
Copy link
Contributor

@vinayakdsci vinayakdsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@ScottTodd ScottTodd merged commit db9d92b into iree-org:main Nov 7, 2024
36 checks passed
@ScottTodd ScottTodd deleted the turbine-colab branch November 7, 2024 15:50
JamesMBartlett pushed a commit to gimletlabs/iree that referenced this pull request Nov 8, 2024
This adapts docs and samples to
https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0.

* Switched from `import shark_turbine.aot as aot` to `import
iree.turbine.aot as aot` (see also
iree-org/iree-turbine#28).
* Redirected notes from `/RELEASING.md` to
https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md.
The release process is changing now with
iree-org#18938 and I'll want to fold the
notes there in to
https://iree.dev/developers/general/release-management/ instead.
* Re-ran some Colab notebooks and adapted to the latest changes across
projects. Note that the
https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample
still has code using `@aot.jittable`, so I have re-opened
iree-org#18564 to migrate it. I spent
some time trying to update it but wasn't sure how to demonstrate dynamic
shapes using the "modern canonical usage" effectively.
* This fixes the recent test failures:
https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934.
Test run:
https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ✏️ Improvements or additions to documentation infrastructure Relating to build systems, CI, or testing integrations/pytorch PyTorch integration work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants