Update function import for when Notebook 7 is present #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @juhasch, is there anyway I can help with the release of |
|
Hi @RRosio, sorry for the delay. I made you admin. |
|
No worries @juhasch, thank you for your help with this! |
mmtevelde
reviewed
Nov 16, 2023
| try: | ||
| from notebook.notebookapp import list_running_servers | ||
| except ModuleNotFoundError: | ||
| from jupyter_server.serverapp import list_runnning_servers |
There was a problem hiding this comment.
Small typo here I think, list_runnning_servers should be list_running_servers
|
@RRosio Hello, is there going to be a new release with this change to support Notebook 7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #1649, this import statement can be updated to import from
jupyter_serverwhen Notebook 7 is present rather than Notebook <= 6.