Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collision_monitor launch file #455

Merged
merged 3 commits into from
Apr 12, 2016

Conversation

fmessmer
Copy link
Member

@fmessmer fmessmer commented Apr 4, 2016

This launch file starts the collision_monitor node that publishes the state_valid topic based on MoveIt! planning scene that is used by cob_safety_controller to stop movements in case of collision.

We might want to add this launch file to all our robots (that use the cob_safety_controller package and have a valid cob_moveit_config)

Note that this introduces a dependency from cob_bringup to cob_manipulation, but I guess this is not a problem....as cob_manipulation is up-to-date and released...

This launch file might also later be used to add the cob_obstacle_distance_moveit node that replaces the component-specific cob_obstacle_distance nodes (see https://github.com/ipa320/cob_control/issues/101)

@ipa-mdl

@floweisshardt
Copy link
Member

if this introduces a dependency to cob_manipulation, we should add cob_manipulation in the metapackage

@fmessmer
Copy link
Member Author

fmessmer commented Apr 4, 2016

no, dependencies are already specified accordingly in the package.xml

@fmessmer
Copy link
Member Author

fmessmer commented Apr 4, 2016

I decided to rename the launch file and already added them to the "affected" robots

@fmessmer fmessmer changed the title add obstacle_monitor launch file add collision_monitor launch file Apr 4, 2016
@fmessmer
Copy link
Member Author

mergin in order to allow @ipa-fxm-cm and @ipa-bfb a cleaner start for their contribution

@fmessmer fmessmer merged commit cf828e4 into ipa320:indigo_dev Apr 12, 2016
@fmessmer fmessmer deleted the add_obstacle_monitor branch April 12, 2016 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants