This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
[DRAFT] Test: (In)valid bundle regression: split test #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 11, 2020 18:40
kwek20
force-pushed
the
invalid-bundle-regression-split
branch
from
bed7f4a
to
fc6a005
Compare
kwek20
force-pushed
the
invalid-bundle-regression-split
branch
from
fc6a005
to
7b2619a
Compare
| @@ -0,0 +1,186 @@ | |||
| from iota.crypto.signing import KeyGenerator | |||
|
|
|||
| from iota import Iota, ProposedTransaction, Address, Bundle, TransactionHash, \ | |||
There was a problem hiding this comment.
| # only updae the trunk reference | ||
| txn.trunk_transaction_hash = previoustx # the previous transaction | ||
| txn.attachment_timestamp = get_current_ms() | ||
|
|
There was a problem hiding this comment.
|
|
||
| api.broadcast_and_store(bundles[0].as_tryte_strings()) | ||
| api.broadcast_and_store(bundles[1].as_tryte_strings()) | ||
|
|
There was a problem hiding this comment.
|
|
||
| argument_list = {'trunk_transaction': trunk2, 'branch_transaction': branch2, | ||
| 'trytes': bundles[1].as_tryte_strings(), 'min_weight_magnitude': 14} | ||
| secondDoubleSpend = Transaction.from_tryte_string( transactions.attach_store_and_broadcast(api, argument_list).get('trytes')[0] ) |
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the split test in #1784 was found to cause trouble with milestones, we decided to remove the test from the original PR and move it to this one.
Thus this PR should not be merged before the original.
Thus only commit from this PR should be: bed7f4a
Fixes #1590
Type of change
Current blocker
Half the time a milestone selects both bundles and corrupts the state
Other half its all good and test succeeds, and like 1 in 20 there is an invalid mwm message from the node as return.