Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Flush column family #1682

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

GalRogozinski
Copy link
Contributor

@GalRogozinski GalRogozinski commented Dec 8, 2019

Description

Delete column family correctly

Fixes #1482

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Ran on dry with rescan
Will be farther validated by the reviewer

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@karimodm karimodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this PR will specifically fix the OOMs caused by:

        if (configuration.isRevalidate()) {
            tangle.clearColumn(com.iota.iri.model.persistables.Milestone.class);
            tangle.clearColumn(com.iota.iri.model.StateDiff.class);
            tangle.clearMetadata(com.iota.iri.model.persistables.Transaction.class);

Let's go ahead and merge

@GalRogozinski
Copy link
Contributor Author

@karimodm
maybe it is unlikely but could the revalidate issue you had could be related to this?

Copy link
Contributor

@karimodm karimodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is probably introducing a database corruption upon --revalidate. Please refer to #1391

@GalRogozinski
Copy link
Contributor Author

@karimodm
just to be clear, did you test again without the PR and you noticed that there is no corruption?

@GalRogozinski GalRogozinski added the L-Test Failed Code should be rewritten label Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
L-Test Failed Code should be rewritten
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOM exception when trying to revalidate a node from the last global snapshot
2 participants