This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Milestone tracker refac #1423
Open
Milestone tracker refac #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsvisabo
requested review from
oopsmonk and
thibault-martinez
as code owners
tsvisabo
added
A-ciri
tsvisabo
force-pushed
the
milestone_tracker_refac
branch
from
af7656c
to
95a6aa3
Compare
tsvisabo
force-pushed
the
milestone_tracker_refac
branch
from
3286485
to
4439624
Compare
tsvisabo
force-pushed
the
milestone_tracker_refac
branch
from
d53d787
to
4439624
Compare
|
For the record, I'd like to properly test this before merging it. I'm currently writing a simple tangle cache to check if storage DB I/O was the bottleneck. So I'd like to test this PR + cache as a whole. |
|
@tsvisabo I believe we can close this ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestedset when node is solidBased on:
https://github.com/iotaledger/iri/pull/1545/files