fix: live reload deploys app when warnings are present #4807 (#5043)

Co-authored-by: Michal Wilski <[email protected]>
ionic-team · Dec 20, 2023 · ef5706e · ef5706e
1 parent 05d64e9
commit ef5706e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/@ionic/cli/src/lib/project/react/serve.ts b/packages/@ionic/cli/src/lib/project/react/serve.ts
@@ -112,7 +112,7 @@ export class ReactServeCLI extends ServeCLI<ReactServeOptions> {
 
     const strippedLine = stripAnsi(line);
 
-    const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
+    const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
     if (compileMsgs.some(msg => strippedLine.includes(msg))) {
       this.emit('ready');
       return false;

diff --git a/packages/@ionic/cli/src/lib/project/vue/serve.ts b/packages/@ionic/cli/src/lib/project/vue/serve.ts
@@ -63,7 +63,7 @@ export class VueServeCLI extends ServeCLI<VueServeOptions> {
     }
 
     const strippedLine = stripAnsi(line);
-    const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
+    const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
     if (compileMsgs.some(msg => strippedLine.includes(msg))) {
       this.emit('ready');
       return false;