Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field key_count_deleted #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fabi755
Copy link
Contributor

@Fabi755 Fabi755 commented Apr 15, 2024

The Lokalise API seems to have changed. The receive process endpoint response with a new field key_count_deleted.

Until now it's not documented. The changelog and the API documentation are not containing any information about this.

We should thinking about to enable ignoreUnknownKeys option. This prevent us from errors when new fields are added by Lokalise.

@StefMa
Copy link
Collaborator

StefMa commented Apr 15, 2024

Thanks @Fabi755 for the PR!
Did you reached out to lokalise and asked if this was an intended change? Maybe it was a mistake? 🤔

Maybe @juschmitt could you help out here to reach out to the lokalise support.

Nevertheless I would definitely opt it for ignoreUnknownKeys!
It could always happen that they add something on their site. Updating this library followed by the LokaliseGradleplugin is a bit of a hassle because of this 😅.

Feel free to create a follow up ticket with only that change and a test 🙏

This one could then wait until we know more about that unknown property.

@Fabi755
Copy link
Contributor Author

Fabi755 commented Apr 15, 2024

Did you reached out to lokalise and asked if this was an intended change? Maybe it was a mistake? 🤔

No, I haven't done that yet

Feel free to create a follow up ticket with only that change and a test 🙏

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants