-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete company #340
base: master
Are you sure you want to change the base?
Add delete company #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can merge once the checks clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I'd complete @rahulgdsouza's comment and add an item to the readme 😄
I've pushed the changes to adapt to your coding standards. I always try to minimize temporary var usage ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs a rebase as it's out-of-date with master. Once that's done I think it's good to go 🚀
9eb9dec
to
285c111
Compare
285c111
to
6a8272a
Compare
✓ Rebased |
This pull request is open for a while now, is it possible to merge this? I would like to implement this feature |
Why?
Make it possible to delete a company from Intercom
How?
By making an API request to the company delete endpoint