Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused import #113

Merged
merged 2 commits into from
Nov 22, 2022
Merged

delete unused import #113

merged 2 commits into from
Nov 22, 2022

Conversation

kouhei
Copy link
Contributor

@kouhei kouhei commented Feb 26, 2022

import { Document } from '@contentful/rich-text-types'; is not need when we don't use richText.
But it contained always.
This may cause failing linter.
So I modified to contain import { Document } from '@contentful/rich-text-types'; when only use it.

I think #106 solved by this PR.

I would be grateful if you review this PR.

@kouhei kouhei changed the title import { Document } when it is used delete unused import Mar 7, 2022
@GabrielAnca
Copy link
Contributor

Hi @kouhei 👋🏻 Your PR looks great. There's a conflict now. Do you mind rebasing and renaming your commit to adhere to the semantic release format? Something like fix(renderContentfulImport): Only import Document when needed would work!

Once that's done I'll get it merged. Thank you!

@kouhei
Copy link
Contributor Author

kouhei commented Nov 22, 2022

Hi @GabrielAnca
Thank you for checking!
I finished modifying the commit message & rebasing.
Please check this again!

Copy link
Contributor

@GabrielAnca GabrielAnca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for this contribution @kouhei 🎉

@GabrielAnca GabrielAnca merged commit 750ab4c into intercom:master Nov 22, 2022
@GabrielAnca
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants