Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Implement new command-list enqueue path #16096

Open
wants to merge 7 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][Graph] Implement new command-list enqueue path #16096

wants to merge 7 commits into from

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Nov 15, 2024 •
edited
Loading

@fabiomestre fabiomestre requested a review from a team as a code owner November 15, 2024 11:47
@fabiomestre fabiomestre mentioned this pull request Nov 15, 2024
Merged
@EwanC EwanC changed the title [UR][Command-Buffers] Implement new command-list enqueue path [SYCL][Graph] Implement new command-list enqueue path Nov 15, 2024
@fabiomestre fabiomestre requested review from a team as code owners November 15, 2024 17:26
EwanC
EwanC approved these changes Nov 18, 2024
View reviewed changes
sycl/doc/design/CommandGraph.md Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
@pbalcer
Copy link
Contributor

pbalcer commented Nov 21, 2024

@fabiomestre please update, the UR PR was merged.

@fabiomestre
Copy link
Contributor Author

@fabiomestre please update, the UR PR was merged.

I have updated the UR commits and repo 👍

@pbalcer
Copy link
Contributor

pbalcer commented Nov 21, 2024

/home/runner/work/llvm/llvm/repo/sycl/doc/design/CommandGraph.md:355: WARNING: 'myst' cross-reference target not found: 'wait-event-path-implementation-details-' [myst.xref_missing]
failure looks related

@fabiomestre
Copy link
Contributor Author

fabiomestre commented Nov 21, 2024 •
edited
Loading

/home/runner/work/llvm/llvm/repo/sycl/doc/design/CommandGraph.md:355: WARNING: 'myst' cross-reference target not found: 'wait-event-path-implementation-details-' [myst.xref_missing] failure looks related

I thnk that issue is fixed. There are 2 other failures but they seem unrelated to this PR

EwanC
EwanC reviewed Nov 22, 2024
View reviewed changes
sycl/cmake/modules/UnifiedRuntimeTag.cmake
# Date: Thu Nov 21 10:55:59 2024 +0100
# Merge pull request #1975 from Bensuo/fabio/immediate_append_exp
# [Command-Buffers] Implement new command-list enqueue path
set(UNIFIED_RUNTIME_TAG 20e501a036e5e16368eb5c8f1e92289efb3ea735)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15843 has merged, which bumps UR past this tag - so I think we can remove touching the tag from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@againull againull againull approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabiomestre @pbalcer @EwanC @againull