Use +sme for Apple #303
Open
Use +sme for Apple #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taiju Yamada <[email protected]>
cielavenir
commented
Nov 9, 2024
| @@ -87,7 +91,7 @@ cdecl(gf_vect_mad_sve): | |||
| /* vector length agnostic */ | |||
| .Lloopsve_vl: | |||
| whilelo p0.b, x_pos, x_len | |||
| b.none .return_pass | |||
| b.eq .return_pass | |||
There was a problem hiding this comment.
According to https://llvm.org/doxygen/AArch64AsmParser_8cpp_source.html , b.none is the same as b.eq when +sve is specified.
|
@liuqinfei could you look into this issue? Thanks again! ;) |
In fact, i don't have an Apple computer that supports SVE on hand. So I can't verify this patch. Maybe you can supply your verifications on the machines with and without SVE. @cielavenir |
|
I don't have either I just checked compilation Thus we need to call for tester(s) with M4 Mac, otherwise we need to wait for the next github RUNNER (not image) update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I went to biccamera ( 😂 ) and checked hw.optional. Then I found FEAT_SME but not FEAT_SVE. 1
This means that for apple the +sve code has to be compiled with +sme instead.
This is potentially quite breaking change, so I'd like this to be tested from those who have M4 Mac.
Call for tester(s): if you have M4 mac, please try running the test on your machine~~
Footnotes
Why Apple says something without FEAT_SVE armv9? ↩