-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added key cache via OS keyring #973
base: master
Are you sure you want to change the base?
Conversation
13476e5
to
7ee1122
Compare
It would be nice to get this merged. I've been waiting patiently in hopes that @int128 will merge this eventually, but that doesn't seem to be the case. I'd also be curious what's missing to get this merged. I also see now that there's conflicts. I'll fix that. |
f1e026f
to
1895099
Compare
Damnit I accidentally clicked "Sync fork" on the wrong branch. Edit: There we go, fixed. Also I've now fixed the merge conflicts |
Would it be possible to expand this to include fetching the client secret from the OS keyring as well? Or is that too much scope creep? |
I would like if that is done in a future PR. I don't have a strong will for trying to implement that |
Changed the
repository.Repository
implementation to use https://github.com/zalando/go-keyringThis means that password tokens are stored in OS keyring instead of in plain text on your disk.
Screenshot from "KDE Wallet Management Tool", the app used to inspect OS keyring on KDE:
Usage:
The code prefers the OS keyring, if supported. Falls back to file based cache. Can be overridden with the new flags:
--force-keyring
--no-keyring
Closes #952