Update tm_t_summary_by() column variable text

[edelarua]

Pull Request

Fixes #1244

Text now aligns with tm_t_summary() column variable text.

[github-actions]

Unit Tests Summary

    1 files     70 suites   1h 9m 30s ⏱️
  724 tests   586 ✅ 110 💤 28 ❌
1 984 runs  1 719 ✅ 225 💤 40 ❌

For more details on these failures, see this check.

Results for commit ad7a78b.

♻️ This comment has been updated with latest results.

[shajoezhu]

lgtm! thanks @edelarua

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	💔	$127.65$	$+8.53$	$0$	$0$	$0$	$0$
shinytest2-tm_a_mmrm	💔	$703.54$	$+35.86$	$0$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	💔	$222.40$	$+12.71$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ci	💔	$96.34$	$+4.94$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	💚	$171.75$	$-27.37$	$0$	$0$	$+13$	$0$
shinytest2-tm_g_forest_tte	💚	$61.28$	$-6.15$	$0$	$0$	$+4$	$0$
shinytest2-tm_g_ipp	💔	$104.42$	$+5.93$	$0$	$0$	$0$	$0$
shinytest2-tm_g_km	💔	$255.31$	$+15.07$	$0$	$0$	$0$	$0$
shinytest2-tm_g_lineplot	💔	$82.91$	$+4.91$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_adverse_events	💔	$117.27$	$+7.19$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_patient_timeline	💔	$227.87$	$+21.47$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_vitals	💔	$81.25$	$+6.68$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality	💔	$64.80$	$+4.02$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality_by_worst_grade	💔	$65.59$	$+3.90$	$0$	$0$	$0$	$0$
shinytest2-tm_t_ancova	💔	$92.71$	$+4.84$	$0$	$0$	$0$	$0$
shinytest2-tm_t_binary_outcome	💔	$73.78$	$+3.95$	$0$	$0$	$0$	$0$
shinytest2-tm_t_coxreg	💔	$69.27$	$+4.95$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events	💔	$56.20$	$+5.68$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_by_grade	💔	$85.79$	$+4.94$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_patyear	💔	$48.17$	$+3.95$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_summary	💔	$60.75$	$+6.23$	$0$	$0$	$0$	$0$
shinytest2-tm_t_exposure	💔	$76.36$	$+2.52$	$0$	$0$	$0$	$0$
shinytest2-tm_t_logistic	💔	$58.75$	$+1.99$	$0$	$0$	$0$	$0$
shinytest2-tm_t_mult_events	💔	$56.35$	$+1.36$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_laboratory	💔	$123.85$	$+6.78$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_medical_history	💔	$65.45$	$+1.70$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm	💔	$56.54$	$+1.81$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm_by_worst	💔	$88.20$	$+1.78$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_grade	💔	$76.41$	$+4.58$	$0$	$0$	$0$	$0$
shinytest2-tm_t_smq	💔	$56.48$	$+3.61$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary_by	💔	$77.81$	$+3.56$	$0$	$0$	$0$	$0$
shinytest2-tm_t_tte	💔	$65.95$	$+2.17$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_mmrm	💔	$9.93$	$+1.07$	e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_t_mmrm_lsmeans.
shinytest2-tm_a_mmrm	💔	$45.63$	$+2.24$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm	💔	$45.06$	$+3.14$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_cov.
shinytest2-tm_a_mmrm	💔	$45.12$	$+3.24$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm	💔	$46.00$	$+2.77$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm	💔	$47.16$	$+1.97$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_g_forest_rsp	💚	$9.66$	$-1.56$	e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.83$	$-1.83$	e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$8.69$	$-1.13$	e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	💚	$8.73$	$-1.14$	e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp	💚	$8.84$	$-1.51$	e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp	💚	$9.81$	$-1.64$	e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.67$	$-1.76$	e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.84$	$-1.02$	e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	💚	$8.56$	$-1.13$	e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp	💚	$8.78$	$-1.18$	e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	💚	$10.29$	$-1.94$	e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.61$	$-1.59$	e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$11.26$	$-2.34$	e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.87$	$-1.73$	e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.88$	$-1.64$	e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$10.10$	$-1.84$	e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	💚	$9.47$	$-1.49$	e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_tte	💚	$9.48$	$-1.21$	e2e_tm_g_forest_tte_Selection_of_arm_var_changes_the_element_and_does_not_throw_validation_errors.
shinytest2-tm_g_forest_tte	💚	$9.27$	$-1.10$	e2e_tm_g_forest_tte_Selection_of_paramcd_changes_the_element_and_does_not_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline	💔	$7.68$	$+1.04$	e2e_tm_g_pp_patient_timeline_Deselecting_dstime_end_throws_validation_error.
shinytest2-tm_g_pp_patient_timeline	💔	$23.78$	$+1.61$	e2e_tm_g_pp_patient_timeline_Encodings_aerelday_start_aerelday_end_dsrelday_start_dsrelday_end_are_shown_only_when_relday_x_axis_is_checked.
shinytest2-tm_g_pp_patient_timeline	💔	$23.99$	$+1.12$	e2e_tm_g_pp_patient_timeline_Encodings_aetime_start_aetime_end_dstime_start_dstime_end_are_shown_only_when_relday_x_axis_is_unchecked.
shinytest2-tm_g_pp_patient_timeline	💔	$7.16$	$+1.05$	e2e_tm_g_pp_patient_timeline_Selecting_aerelday_start_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline	💔	$6.97$	$+1.25$	e2e_tm_g_pp_patient_timeline_Selecting_dsrelday_end_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline	💔	$7.00$	$+1.29$	e2e_tm_g_pp_patient_timeline_Selecting_dsrelday_start_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline	💔	$8.43$	$+1.08$	e2e_tm_g_pp_patient_timeline_Selecting_dstime_end_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_vitals	💔	$8.30$	$+1.06$	e2e_tm_g_pp_vitals_Selecting_valid_paramcd_and_paramcd_levels_vals_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_t_events	💔	$6.76$	$+1.00$	e2e_tm_t_events_Deselection_of_llt_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_events_summary	💔	$7.70$	$+1.06$	e2e_tm_t_events_summary_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_shift_by_grade	💔	$10.49$	$+1.14$	e2e_tm_t_shift_by_grade_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_summary_by	💔	$23.81$	$+1.42$	e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 209c285

♻️ This comment has been updated with latest results.

[edelarua]

@shajoezhu some unrelated shinytest2 tests are failing (the same ones that have been failing in the integration tests for a while). Is someone looking into this already?

[shajoezhu]

@shajoezhu some unrelated shinytest2 tests are failing (the same ones that have been failing in the integration tests for a while). Is someone looking into this already?

hey @pawelru @gogonzo @donyunardi , I was wondering if you guys had seen this before. Thanks