Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Is it possible to change label of arm_var in "tm_t_summary_by" shown on left sidebar panel? #1244

Closed
3 tasks done
Mia-data opened this issue Nov 7, 2024 · 5 comments · Fixed by #1247
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request sme

Comments

@Mia-data
Copy link

Mia-data commented Nov 7, 2024

What is your question?

in tm_t_summary" arm_var is labelled in the left-sde panel as "Select Column(s) variable" which is great. However, arm_var parameter is tm_t_summary_by is labelled "Select Treatment Variable" which is may not be true for all available variables to be selected. Is is possible to customize label of arm_var in tm_t_summary_by that is shown in left sidebar panel?

and here attached picture what I mean
arm_var name

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@Mia-data Mia-data added the question Further information is requested label Nov 7, 2024
@llrs-roche
Copy link

Hi Milena, looking at the help page it doesn't seem like it is customizable. Are you suggesting to change it to a more general one like "Select Variable" or would you like something like this for other data (this one has some particularities for clinical data from ADaM datasets)?

@Mia-data
Copy link
Author

@llrs-roche Exactly, I'm suggesting to name it in tm_t_summary_by to sth more generalizable for example "Select Column Variable" - as it was already done for tm_t_summary. Because a variable used in columns to splitvariables not neccessairuly must be treatment arm, for example this module can be used to analyse data from one arm with columns by age group. (I know I can select multiple columns for splitting by for the sake of simplicity and interest I wanna narrow focus to one arm). Thus labeling column variable to sth more generalizable would be very helpful.

@m7pr
Copy link
Contributor

m7pr commented Nov 12, 2024

@Melkiades any thoughts on this?

@shajoezhu
Copy link
Contributor

hi @Mia-data , many thanks for the suggestion.

yes, I think we can just simply change it to "Select Column Variable" and making things consistent

@Mia-data
Copy link
Author

Mia-data commented Nov 14, 2024

@shajoezhu Great, thank you for your flexibility and openness for feedback :)

@edelarua edelarua self-assigned this Nov 14, 2024
@edelarua edelarua added sme enhancement New feature or request and removed question Further information is requested labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants