-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure analysis results + add visit variable to pool data.frame #362
base: main
Are you sure you want to change the base?
Conversation
Hey @pengguanya , Apologies for leaving this so long. Just to say I got around to fixing the issue that was blocking the CICD tests. We also had to create an emergancy update for the package which I've merged into your branch here for you. That being said now that the unit tests are running I am seeing some failures on this PR: The vignettes don't appear to be working: Theres an issue with the document() function but I need to look into that myself. Also looks like some of the snapshot tests have updated which I don't think I was expecting to happen: |
@gowerc @nociale
update based on 255-01
dplyr
,rlang
,purrr
related functions to baseassert_that
instead ofstop_if_not
NA
valuesTests are passed for
analyse
,analysis_result
,ancova
andutilities
, but there are still tests and functions (mainlypool
relevant ones) need to be updated. I will look into that while updatingpool
next week