Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure analysis results + add visit variable to pool data.frame #362

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

pengguanya
Copy link
Collaborator

@pengguanya pengguanya commented May 24, 2022

@gowerc @nociale
update based on 255-01

  • convert all dplyr, rlang, purrr related functions to base
  • use assert_that instead of stop_if_not
  • add and update tests for utility,analysis and ancova functions
  • make new analysis result class correctly handle NA values
  • fix some bugs

Tests are passed for analyse, analysis_result, ancova and utilities, but there are still tests and functions (mainly pool relevant ones) need to be updated. I will look into that while updating pool next week

image

pengguanya and others added 30 commits April 27, 2022 20:54
@pengguanya
Copy link
Collaborator Author

@gowerc @nociale
The pool function has been updated and it works now with the new analysis_result class. All tests in test-pool.R are passed. I do have a few questions though and will post in the the discussion together with relevant code.

image

image

@pengguanya
Copy link
Collaborator Author

@gowerc @nociale
Final update is done and full tests passed. Please review
image

@gowerc gowerc changed the title 255 02 Restructure analysis results + add visit variable to pool data.frame Jul 8, 2022
@gowerc
Copy link
Collaborator

gowerc commented Oct 20, 2022

Hey @pengguanya ,

Apologies for leaving this so long. Just to say I got around to fixing the issue that was blocking the CICD tests. We also had to create an emergancy update for the package which I've merged into your branch here for you. That being said now that the unit tests are running I am seeing some failures on this PR:

The vignettes don't appear to be working:
https://github.com/insightsengineering/rbmi/actions/runs/3291480479/jobs/5425686328

Theres an issue with the document() function but I need to look into that myself.

Also looks like some of the snapshot tests have updated which I don't think I was expecting to happen:
https://github.com/insightsengineering/rbmi/actions/runs/3291480281/jobs/5425685856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide variable in pool dataframe showing which visit the row belongs to
2 participants