PLT-7616 set api call for config json needed for dynamic setting of m… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arlowe runtime web url
nhenin
reviewed
Oct 12, 2023
src/index.tsx
Outdated
| } | ||
| }); | ||
|
|
||
| const hasValidRuntimeInstance = runtimeURL !== undefined && runtimeURL !== null && runtimeURL !== '' && runtimeURL.startsWith('http'); |
There was a problem hiding this comment.
there is a healthcheck endpoint available in the sdk, you should call it instead
There was a problem hiding this comment.
This check is not good enough
There was a problem hiding this comment.
It's something along these lines if I'm not mistaken:
import { mkRestClient } from "@marlowe.io/runtime-rest-client";
const restClient = mkRestClient(runtimeURL)
const hasValidRuntimeInstance = await restClient.healthcheck()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arlowe runtime web url
This PR prevents that app from running if the marlowe runtime web url is not set in the env keys or in a config.json in the public folder.
The config.json should be set as follows:
{
"marloweWebServerUrl": "https://marlowe-runtime-preprod-web.scdev.aws.iohkdev.io/",
"develMode": false
}
We need this change so that the deploy sets the marlowe web url instance dynamically in the config.json file.