fix: [lw-11844]: handle withdrawals in tx history #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetalcore
commented
Nov 21, 2024
Allure Report
processReports: ✅ test report for 37f94c9f
|
vetalcore
force-pushed
the
fix/lw-11844-handle-withdrawals-tx-in-tx-history
branch
from
68f11a4
to
dae1c4b
Compare
vetalcore
force-pushed
the
fix/lw-11844-handle-withdrawals-tx-in-tx-history
branch
from
dae1c4b
to
37f94c9
Compare
|
mchappell
approved these changes
Nov 27, 2024
vetalcore
deleted the
fix/lw-11844-handle-withdrawals-tx-in-tx-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Since tx total amount calculation is affected we should compare the value displayed in nami mode vs lace;
Screenshots
Attach screenshots here if implementation involves some UI changes