-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [LW-11802] enable strict null checks #1536
Open
mchappell
wants to merge
38
commits into
main
Choose a base branch
from
refactor/enable-strict-null-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchappell
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 13, 2024 13:23
ecc7e39
to
6403476
Compare
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 25, 2024 13:30
96cf58c
to
14263c6
Compare
Allure Report
processReports: ❌ test report for 1d39407e
|
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
2 times, most recently
from
November 25, 2024 14:27
6687d69
to
1e203e4
Compare
vetalcore
changed the title
Refactor/enable strict null checks
refactor: [LW-11802] enable strict null checks
Nov 25, 2024
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
6 times, most recently
from
November 26, 2024 12:35
e91f097
to
19253b5
Compare
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 28, 2024 12:04
19253b5
to
90841fa
Compare
- separate tags requiring co-signer and those which dont - enable strict checks on expected process variables - update function return types to include nulls
…operties as optional
- add translation package to tsconfig references
… props with default fallback
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 29, 2024 12:04
90841fa
to
dc46640
Compare
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 29, 2024 12:12
dc46640
to
a2f5018
Compare
vetalcore
approved these changes
Nov 30, 2024
vetalcore
force-pushed
the
refactor/enable-strict-null-checks
branch
from
November 30, 2024 11:18
6425a69
to
1d39407
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes