Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [LW-11802] enable strict null checks #1536

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

mchappell
Copy link
Collaborator

@mchappell mchappell commented Nov 13, 2024

Checklist

  • JIRA - LW-11802
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@mchappell mchappell force-pushed the refactor/enable-strict-null-checks branch from ecc7e39 to 6403476 Compare November 13, 2024 13:23
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch from 96cf58c to 14263c6 Compare November 25, 2024 13:30
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 25, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ❌ test report for 1d39407e

passed failed skipped flaky total result
Total 30 2 4 0 36

@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch 2 times, most recently from 6687d69 to 1e203e4 Compare November 25, 2024 14:27
@vetalcore vetalcore changed the title Refactor/enable strict null checks refactor: [LW-11802] enable strict null checks Nov 25, 2024
@vetalcore vetalcore self-assigned this Nov 25, 2024
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch 6 times, most recently from e91f097 to 19253b5 Compare November 26, 2024 12:35
@vetalcore vetalcore marked this pull request as ready for review November 26, 2024 13:02
@vetalcore vetalcore requested review from a team as code owners November 26, 2024 13:02
@vetalcore vetalcore self-requested a review November 26, 2024 13:21
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch from 19253b5 to 90841fa Compare November 28, 2024 12:04
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch from 90841fa to dc46640 Compare November 29, 2024 12:04
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch from dc46640 to a2f5018 Compare November 29, 2024 12:12
@vetalcore vetalcore force-pushed the refactor/enable-strict-null-checks branch from 6425a69 to 1d39407 Compare November 30, 2024 11:18
Copy link

sonarcloud bot commented Nov 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants