Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs): Update the readme file #18

Merged
merged 1 commit into from
Jan 17, 2024
Merged

build(docs): Update the readme file #18

merged 1 commit into from
Jan 17, 2024

Conversation

hamada147
Copy link

Update the readme file.

@hamada147 hamada147 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 11, 2024
@hamada147 hamada147 self-assigned this Jan 11, 2024
FabioPinheiro
FabioPinheiro requested changes Jan 11, 2024
View reviewed changes
Copy link

@FabioPinheiro FabioPinheiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs LGTM.
But what organisation/groupId name is this io.iohk.atala.prism.anoncredskmp?
Why not io.iohk.atala?

@hamada147
Copy link
Author

What organisation name is this io.iohk.atala.prism.anoncredskmp? Why not io.iohk.atala?

Hey @FabioPinheiro,
All our KMP projects have the same beginning for the group ID io.iohk.atala.prism then the project name. For this project it is anoncredskmp.
We have Apollo as io.iohk.atala.prism.apollo and we have the DIDPeer as io.iohk.atala.prism.didcomm and for wallet SDK we have io.iohk.atala.prism.walletsdk
That's why we have this package as io.iohk.atala.prism.anoncredskmp

FabioPinheiro
FabioPinheiro approved these changes Jan 11, 2024
View reviewed changes
Copy link

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't even know what to say

@hamada147 hamada147 merged commit f9f2624 into main Jan 17, 2024
2 checks passed
@hamada147 hamada147 deleted the update-readme branch March 2, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

Assignees

@hamada147 hamada147

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamada147 @FabioPinheiro