-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ICS 08 Wasm clients wrapping an ICS 07 Tendermint client #3958
Draft
romac
wants to merge
23
commits into
master
Choose a base branch
from
romac/wasm-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 07 Tendermint client (#3943) * Add skeleton for ICS 08 Wasm client * Add support for Wasm clients wrapping an ICS 007 Tendermint client * Introduce an enum for the underlying client of a WASM client * Add `ibc-go-v7-wasm-simapp` to `flake.nix` * Add Wasm option to ClientSettings * Support building Wasm client state in Cosmos chain * Preliminary refactor * Change CreateOptions to an enum to eventually enable creating clients of various types * Add Wasm client options to CreateOptions * Add `--wasm-checksum` option to `create client` * Update templates * Allow creating 08-wasm clients wrapping a 07-tendermint client * WIP: Allow updating a 08-wasm client wrapping a 07-tendermint client * Cleanup * Add compiled WASM client for testing purposes * Use Python scripts to enable Wasm clients and install them * Integration test for creating and updating 08-wasm clients * Fix GitHub job * Cleanup * Fix + debug * Remove contract data * Remove `--gas auto` in order to use provided `fees` instead * Remove hardcoded fees when storing contract * Remove Python scripts and top-level Wasm blob Get them from this gist instead: https://gist.github.com/romac/80eddfd304ec03562badf23d9b43f892 * Remove gm.toml * Auto-detect compat mode in async_icq query * Remove COMPAT_MODES env variable * Remove debug statement * Add more debug * Only run Wasm client test in wasm job * Fix test * Allow clients to be force refreshed * Increase trusting period * Cleanup * Update Wasm client * Revert "Increase trusting period" This reverts commit bff7bdf. * Ignore Wasm contract artifacts * Cleanup * Add `force_refresh` method instead of `force: bool` parameter on `refresh` * Apply suggestions from code review
romac
force-pushed
the
romac/wasm-client
branch
from
April 22, 2024 12:10
fbed173
to
c792cc4
Compare
romac
force-pushed
the
romac/wasm-client
branch
from
April 22, 2024 12:14
c792cc4
to
13b91a1
Compare
* Use Nix to build the CosmWasm IBC client contract * Cleanup
ljoss17
requested changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits
Co-authored-by: Luca Joss <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3951
PRs
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.