Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for complete channel upgrade handshake #3256

Closed
5 tasks
Tracked by #2547
ljoss17 opened this issue Apr 19, 2023 · 1 comment
Closed
5 tasks
Tracked by #2547

Add integration tests for complete channel upgrade handshake #3256

ljoss17 opened this issue Apr 19, 2023 · 1 comment
Assignees
@ljoss17
Labels
O: channel-upgradeability Objective: related to channel upgradeability O: tests Objective: Test more aspect of the relayer

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Apr 19, 2023

Summary

Add tests for different channel upgrade scenarios.

Proposal

Add tests for the following channel upgrade cases:

  • 4 tests, for upgrading each individual field:
    • upgrading Version
    • upgrading ConnectionHops
    • upgrading Ordering from Ordered to Unordered accepted
    • upgrading Ordering from Unordered to Ordered rejected
  • 3 tests, for the different timeouts possibilities:
    • only TimeoutHeight set
    • only TimeoutTimestamp set
    • both TimeoutHeight and TimeoutTimestamp set
  • 1 test for ChannelUpgradeCancelMsg

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Apr 19, 2023
@ljoss17 ljoss17 self-assigned this Apr 19, 2023
@ljoss17 ljoss17 added O: tests Objective: Test more aspect of the relayer O: channel-upgradeability Objective: related to channel upgradeability labels Apr 19, 2023
@ljoss17 ljoss17 mentioned this issue Apr 19, 2023
Closed
@seanchen1991 seanchen1991 added this to the v1.5 milestone Apr 19, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Apr 19, 2023
@seanchen1991 seanchen1991 mentioned this issue Apr 20, 2023
Closed
5 tasks
@romac romac modified the milestones: v1.5, v1.6 May 24, 2023
@romac romac modified the milestones: v1.6, v1.7 Jun 6, 2023
@seanchen1991 seanchen1991 moved this from 📥 Todo to 🏗 In progress in Hermes Sep 19, 2023
@seanchen1991 seanchen1991 modified the milestones: v1.7, v1.8 Sep 19, 2023
@romac romac modified the milestones: v1.8, v1.9 Jan 16, 2024
@adizere adizere removed this from the v1.9 milestone Apr 2, 2024
@ljoss17
Copy link
Contributor Author

ljoss17 commented Jul 8, 2024

Done by #3228

@ljoss17 ljoss17 closed this as completed Jul 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
O: channel-upgradeability Objective: related to channel upgradeability O: tests Objective: Test more aspect of the relayer
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@romac @adizere @seanchen1991 @ljoss17