Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for channel upgradability #2547

Closed
8 of 9 tasks
adizere opened this issue Aug 11, 2022 · 0 comments · Fixed by #3228
Closed
8 of 9 tasks

Add support for channel upgradability #2547

adizere opened this issue Aug 11, 2022 · 0 comments · Fixed by #3228
Assignees
@seanchen1991 @ljoss17
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: okr Admin: tracks an ongoing OKR A: tracking Admin: tracks smaller units of work I: logic Internal: related to the relaying logic I: protocol Internal: related to IBC protocol changes (eg. v2 update) O: channel-upgradeability Objective: related to channel upgradeability O: new-feature Objective: cause to add a new feature or support
Milestone
v1.9

Comments

@adizere
Copy link
Member

adizere commented Aug 11, 2022 •
edited by romac
Loading

Summary

Spec here:
https://github.com/cosmos/ibc/blob/main/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md

I expect this to look very similarly with the relayer fees upgrade.

Core implementation
Beta Give feedback

CLI Tasks
Beta Give feedback
  1. Add channel upgrade init and try tx commands #3237
    I: CLI O: channel-upgradeability
    seanchen1991
  2. Add channel upgrade ack and confirm tx commands #3238
    I: CLI O: channel-upgradeability
    seanchen1991
  3. Add user-facing channel upgrade command #3239
    I: CLI O: channel-upgradeability
    seanchen1991

Channel Worker Tasks
Beta Give feedback
  1. Update the channel worker to perform the upgrade handshake #3243
    I: CLI O: channel-upgradeability
    ljoss17 seanchen1991

Testing Tasks
Beta Give feedback
  1. Add integration tests for complete channel upgrade handshake #3256
    O: channel-upgradeability O: tests
    ljoss17
  2. Add integration tests for ChannelUpgradeInit step #3246
    O: channel-upgradeability O: tests
    ljoss17
  3. Add integration test for ChanUpgradeTry step #3254
    O: channel-upgradeability O: tests
    ljoss17
  4. Add integration test for ChanUpgradeAck step #3255
    O: channel-upgradeability O: tests
    ljoss17

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the v1.3 milestone Aug 11, 2022
@adizere adizere added the I: dependencies Internal: related to dependencies label Aug 11, 2022
@adizere adizere added this to Hermes Dec 13, 2022
@adizere adizere moved this to 📋 Backlog in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 modified the milestones: v1.3, Backlog Dec 13, 2022
@seanchen1991 seanchen1991 modified the milestones: Backlog, v1.5 Feb 21, 2023
@seanchen1991 seanchen1991 moved this from 📋 Backlog to 📥 Todo in Hermes Feb 21, 2023
@romac romac added O: new-feature Objective: cause to add a new feature or support I: protocol Internal: related to IBC protocol changes (eg. v2 update) A: critical Admin: critical or important I: logic Internal: related to the relaying logic and removed I: dependencies Internal: related to dependencies labels Mar 27, 2023
@seanchen1991 seanchen1991 added O: channel-upgradeability Objective: related to channel upgradeability A: okr Admin: tracks an ongoing OKR labels Mar 31, 2023
@seanchen1991 seanchen1991 moved this from 📥 Todo to 🏗 In progress in Hermes Mar 31, 2023
@seanchen1991 seanchen1991 added A: okr Admin: tracks an ongoing OKR and removed A: okr Admin: tracks an ongoing OKR labels Apr 5, 2023
@seanchen1991 seanchen1991 mentioned this issue Apr 7, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 assigned ljoss17 and unassigned ljoss17 Apr 11, 2023
@seanchen1991 seanchen1991 added the A: tracking Admin: tracks smaller units of work label Apr 12, 2023
@romac romac modified the milestones: v1.5, v1.6 May 24, 2023
@seanchen1991 seanchen1991 modified the milestones: v1.6, v1.7 Jun 1, 2023
@seanchen1991 seanchen1991 moved this from 🏗 In progress to 🛑 Blocked in Hermes Jun 6, 2023
@seanchen1991 seanchen1991 added A: blocked Admin: blocked by another (internal/external) issue or PR and removed A: critical Admin: critical or important labels Jun 6, 2023
@seanchen1991 seanchen1991 mentioned this issue Jun 27, 2023
Closed
3 tasks
@romac romac moved this from 🛑 Blocked to 🏗 In progress in Hermes Jul 24, 2023
@romac romac removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Jul 24, 2023
@seanchen1991 seanchen1991 removed the status in Hermes Jul 26, 2023
@seanchen1991 seanchen1991 added the A: blocked Admin: blocked by another (internal/external) issue or PR label Jul 26, 2023
@seanchen1991 seanchen1991 moved this to 🏗 In progress in Hermes Sep 7, 2023
@seanchen1991 seanchen1991 removed the status in Hermes Sep 7, 2023
@seanchen1991 seanchen1991 modified the milestones: v1.7, v1.8 Sep 7, 2023
@romac romac modified the milestones: v1.8, v1.9 Jan 18, 2024
@adizere adizere moved this to 🏗 In progress in Hermes Mar 26, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanchen1991 seanchen1991

@ljoss17 ljoss17

Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: okr Admin: tracks an ongoing OKR A: tracking Admin: tracks smaller units of work I: logic Internal: related to the relaying logic I: protocol Internal: related to IBC protocol changes (eg. v2 update) O: channel-upgradeability Objective: related to channel upgradeability O: new-feature Objective: cause to add a new feature or support
Projects
Hermes
Status: ✅ Done
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

Channel upgradability informalsystems/hermes
4 participants
@romac @adizere @seanchen1991 @ljoss17