Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pay amount field to tx_execute #275

Merged
merged 4 commits into from
Nov 2, 2024
Merged

feat: add pay amount field to tx_execute #275

merged 4 commits into from
Nov 2, 2024

Conversation

dangush
Copy link
Contributor

@dangush dangush commented Oct 25, 2024

Summary

Our CwClient trait is missing the pay_amount field under tx_execute.

This missing field is necessary for running cycles demo3, so this PR adds it in.

Note: the field is not yet utilized in the pure rust trait impl.

@dangush dangush marked this pull request as ready for review October 30, 2024 22:37
@dangush dangush requested a review from hu55a1n1 October 30, 2024 22:39
@dangush
Copy link
Contributor Author

dangush commented Oct 30, 2024

This breaks CliClient usage in examples/pingpong, but that project doesn't compile ATM anyway so we can merge this and fix that in another pr

@ebuchman ebuchman merged commit d12343a into main Nov 2, 2024
8 checks passed
@ebuchman ebuchman deleted the dangush/cli-payamount branch November 2, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@hu55a1n1 hu55a1n1 Awaiting requested review from hu55a1n1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangush @ebuchman