Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Namada repository #250

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Apr 24, 2024

No description provided.

"zcash_encoding-0.2.0" = "sha256-keuaoM/t1Q/+8JMemMMUuIo4g5I/EAoONFge+dyWGy0=";
};
};
preBuild = ''
export RUSTUP_TOOLCHAIN="1.77.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to Namada, or is this only for setting the Rust toolchain version?

If the latter, I believe you can instead do this by defining your own rustPlatform using https://github.com/oxalica/rust-overlay (which is already enabled in the flake) and then using that instead of pkgs.rustPlatform:

{ pkgs, namada-src }:
let
  rust = pkgs.rust-bin.stable."1.77.1".default;

  rustPlatform = nixpkgs.makeRustPlatform {
    cargo = rust;
    rustc = rust;
  };
in
rustPlatform.buildRustPackage {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced for Namada specifically, after getting this error, https://github.com/informalsystems/cosmos.nix/actions/runs/8814425645/job/24194232530#step:6:2066, it seemed without the RUSTUP_TOOLCHAIN it was still using v1.75 which didn't have the fix.

@romac
Copy link
Member

romac commented May 29, 2024

Let's figure out if we can only attempt to build Namada on Linux, so that we don't fail the macOS build unnecessarily.

Aside from that, not sure how to work around the issues with the Linux GitHub runner without using a self-hosted runner.

Nevermind the approval above, let's keep this in draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants