[0.18.0-iap] Remove all contrib extensions #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrib extensions are not packaged with Imply Druid. This will help speed up build time as we no longer have to compile the extensions only to throw them away later in the build process. The only 2 that were packaged in older versions have been removed in 3.3 https://github.com/implydata/distribution/blob/1d86be2ebaca32a511fb298f126fd5c3becf006e/src/build/druid#L180
|
@imply-rjenkins Will the fact that I removed the bundle contrib extensions profile break something in the distribution repo? The line I linked to above looks like it's removing an already compiled extension. Can you test if this change works with the distribution repo - or are there any changes needed there as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrib extensions are not packaged with Imply Druid. This will help speed
up build time as we no longer have to compile the extensions only to throw
them away later in the build process.
The only 2 that were packaged in older versions have been removed in 3.3.x
https://github.com/implydata/distribution/blob/1d86be2ebaca32a511fb298f126fd5c3becf006e/src/build/druid#L180