Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to handle Union of datasources and date as column 1 #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jyshekhar-git
Copy link

Modified code to fix bug to handle union.
original json file had something like:
queryId = query['query']['context']['queryId']
Modified the code to remove this and all instances of ['query']

@jyshekhar-git
Copy link
Author

Reason for the change is because the ['query'] in the code was throwing an error of the type:
dataSource = "'" + query['query']['dataSource']['dataSources'][0]['name'] + "|" + query['query']['dataSource']['dataSources'][1]['name'] + "'"
~~~~~^^^^^^^^^
KeyError: 'query'

Also added code for groupBy

@imply-khoondert
Copy link
Collaborator

Hi @jyshekhar-git - thanks for the PR - I don't think we want to keep changing the code each time a customer has a different log format... I think it might be better if we make it an option?
This way we use the Imply default way as the default position of the query, but if the query is in a different position we could add a parameter to the command line to say what field the query is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants