Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM::Controller: add hook to render metadata in the same context #193

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisandreae
Copy link
Member

This would permit metadata serialization to contribute referenced viewmodels.

This would permit metadata serialization to contribute referenced viewmodels.
@chrisandreae
Copy link
Member Author

chrisandreae commented May 30, 2023

Oh, one awkward thing here is that this wouldn't place nicely with the prerender_json_view used to render cached content, because in that the references are already preserialized as json and there's no serialize context to contribute more to. That alone is probably a blocker for this idea, unless you've got any insight.

I suppose it could construct an ad-hoc serialize context and then carefully merge that with the preserialized references, but that's mildly painful.

@chrisandreae chrisandreae marked this pull request as draft May 30, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants