Global: only sectors, no aggregates #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkikstra I changed the base PR for this to |
gidden
force-pushed
the
global-sectors
branch
from
07805e0
to
d20f190
Compare
|
Hey @jkikstra, figured out the issue here. One option provided for submissions is to provide |
|
Ah yes, I had not checked for overrides! Perfect, thanks for checking this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test which has only global region and two sectors (building on #15 ).
Notes:
at the moment the tests fail, because the the test data is marginally different from the harmonized input. I have copied the test data values from the original
test_regions_sectors.xlsxfile.in the RunControl file,
global_harmonization_onlyis set tofalse, despite there only being global harmonization, because 'global_harmonization' in the current implementation means that there is no sectoral breakdown.As the title suggests, this does not yet test for a mixed case with aggregates for all but CO2 (which could e.g. be split up in AFOLU and Fossil Fuel emission sectors)