-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Unittest tester from FORCE #2382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caleb-sitton-inl can you modify a unit-test in raven to use this new tester so we have some testing on this new feature of the testing harness? Thanks!
@dylanjm For sure! No problem! |
Job Test qsubs sawtooth on 8033dd2 : invalidated by @joshua-cogliati-inl sawtooth back up |
@caleb-sitton-inl Looks like your test is failing the pylint portion with this error:
Go ahead and fix that and recommit. Thanks! |
Job Mingw Test on 2477df8 : invalidated by @GabrielSoto-INL |
Looks like the Mingw Test is failing due to a single test: Error message for the test (the relevant parts copied from the Civet test results): @joshua-cogliati-inl Do you know if this is a common error? I don't think anything that @caleb-sitton-inl added in this PR should be messing with the parallel tests. Seeing a lot of these types of errors in the stack trace:
|
See #2392. Once we have approval to apply the exception to that test, we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is approved to merge. A test has been modified to utilize this new UnitTester rook module so it will be leveraged in all future tests. The Windows tests are currently failing due to an issue outside of this PR -- #2392 has approved merging PRs failing these specific tests until its resolved. There are some plugin failures that appear to be caused by something outside of this PR. The authors of the plugins have been notified.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#2381
What are the significant changes in functionality due to this change request?
This adds a tester to specifically deal with running tests through rook that use the unittest module. It was initially created in FORCE (see https://github.com/idaholab/FORCE/pull/35).
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.