Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logos submodule ID #1227

Merged
merged 22 commits into from
May 6, 2020
Merged

update logos submodule ID #1227

merged 22 commits into from
May 6, 2020

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented May 4, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

see issue #1114

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 requested a review from mandd May 4, 2020 23:13
@moosebuild
Copy link

Job Test Fedora 28 on 8657c8f : invalidated by @mandd

@moosebuild
Copy link

Job Mingw Test on 8657c8f : invalidated by @mandd

@wangcj05
Copy link
Collaborator Author

wangcj05 commented May 5, 2020

@mandd Windows is currently failed on DEVEL due to the unstable test of limit surface error bound.

@wangcj05
Copy link
Collaborator Author

wangcj05 commented May 5, 2020

@mandd I have disabled the limit surface error bounding test as I discussed with @alfoa . Now all tests are green, and this PR is ready now.

@alfoa
Copy link
Collaborator

alfoa commented May 6, 2020

PR check list passed...

One of the tests got disabled as decided in the RAVEN team meeting

@alfoa alfoa merged commit 3101996 into devel May 6, 2020
@alfoa alfoa deleted the wangc/LOGOS_plugin branch May 6, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants