Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRAW plugin #1175

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Add SRAW plugin #1175

merged 5 commits into from
Mar 27, 2020

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Mar 11, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #1190

Ref. #1114

What are the significant changes in functionality due to this change request?

Plugin contains template functionalities for plant health management and asset management.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Test CentOS 8 on e2d31eb : invalidated by @alfoa

3 similar comments
@moosebuild
Copy link

Job Test CentOS 8 on e2d31eb : invalidated by @alfoa

@moosebuild
Copy link

Job Test CentOS 8 on e2d31eb : invalidated by @alfoa

@moosebuild
Copy link

Job Test CentOS 8 on e2d31eb : invalidated by @alfoa

@moosebuild
Copy link

Job Mingw Test on e2d31eb : invalidated by @wangcj05

fetching takes more than two hours

@moosebuild
Copy link

Job Mingw Test on e2d31eb : canceled by @wangcj05

@wangcj05 wangcj05 changed the title add SRAW plugin WIP: add SRAW plugin Mar 11, 2020
@wangcj05 wangcj05 changed the title WIP: add SRAW plugin Add SRAW plugin Mar 26, 2020
@wangcj05 wangcj05 requested a review from alfoa March 26, 2020 15:11
@wangcj05
Copy link
Collaborator Author

@alfoa Could you take a look at this PR?

@alfoa alfoa added the RAVENv2.0 Defects and Features in release of RAVEN v2.0 label Mar 27, 2020
@alfoa alfoa mentioned this pull request Mar 27, 2020
10 tasks
@alfoa alfoa added the plugins label Mar 27, 2020
@alfoa
Copy link
Collaborator

alfoa commented Mar 27, 2020

PR approved...

Checklist passed...

Merging...

@alfoa alfoa merged commit 5750e5c into devel Mar 27, 2020
@alfoa alfoa deleted the wangc/SRAW_plugin branch March 27, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins RAVENv2.0 Defects and Features in release of RAVEN v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] SRAW Plugin
3 participants