[WIP] Add an implementation of ReadAsync to ZipAESStream #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which would be the fastest change if we want a fix ASAP, but not as nice as a real async impl, which fits in more with the other async supporting changes. |
Numpsy
commented
Feb 14, 2021
This was referenced Feb 14, 2021
Merged
This was referenced Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #572
Add an implementation of ReadAsync to ZipAESStream, with associated StreamUtils change and a copy/pasted unit test (that currently fails on .NETCore 3.1 due to #572).
WIP because:
There is still a bunch of duplication between ReadAndTransform/ReadAndTransformAsync, and the copy/pasted signature of TransformFromSlideBuffer doesn't feel ideal.
Looking at ZipFile.GetInputStream a bit more, I don't think it will actually do async reads from the base stream unless
PartialInputStreamis given some async support as well, so the current code might not actually be any 'more' async that just makingReadAsynccallReadsynchrounously and then returning the result.I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.