Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getStarted): Add info callout for send test message limitation #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mo-Hussain
Copy link
Contributor

@Mo-Hussain Mo-Hussain commented Aug 28, 2024

  • I didn't see this when skimming it and thought a callout would be helpful

image

@Mo-Hussain Mo-Hussain requested a review from ltyu August 28, 2024 15:38
@Mo-Hussain Mo-Hussain self-assigned this Aug 28, 2024
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyp-v3-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:38pm

@@ -128,10 +128,11 @@ To send a test message, run:
```bash
hyperlane send message --relay
```

:::info
Currently core self-relay only works **from Holesky** **to your custom chain**. When dispatch is successful, you should see that the message was self-relayed!
Copy link
Contributor Author

@Mo-Hussain Mo-Hussain Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltyu - I was able to self relay from Sepolia, is it supposed to only be from Holesky?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes other origins should work now

@@ -128,10 +128,11 @@ To send a test message, run:
```bash
hyperlane send message --relay
```

:::info
Currently core self-relay only works **from Holesky** **to your custom chain**. When dispatch is successful, you should see that the message was self-relayed!

Support in the CLI for other origin chains is being added; chains that are not supported will output `Error: No fallback hook config found`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a different error message, should we remove the specific error message from here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was fixed by @yorhodes. if this is no longer an issue, we can remove that specific error message. I believe relaying from custom chain to existing chain is still not possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what error did you see @Mo-Hussain ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think we should callout that self relay from custom chain to aw managed chain will not work

Copy link
Member

@yorhodes yorhodes Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self relay from custom chain to aw managed chain will not work

this will work if there is a supported ISM configured on the aw managed chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants