feat: Add hook update into WarpModule.update() #4891
+384
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orepo into ltyu/warp-apply-hook
… such that it updates a warp route _without_ a hook, and one with an existing hook.
🦋 Changeset detectedLatest commit: abab8a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmrossy
changed the title
…orepo into ltyu/warp-apply-hook
…orepo into ltyu/warp-apply-hook
ltyu
force-pushed
the
ltyu/warp-apply-hook
branch
from
0798188
to
adaf990
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4891 +/- ##
=======================================
Coverage 74.60% 74.60%
=======================================
Files 103 103
Lines 1516 1516
Branches 195 195
=======================================
Hits 1131 1131
Misses 364 364
Partials 21 21
|
…orepo into ltyu/warp-apply-hook
ltyu
changed the title
ltyu
changed the title
jmrossy
approved these changes
Nov 29, 2024
| @@ -42,12 +46,14 @@ import { EvmERC20WarpRouteReader } from './EvmERC20WarpRouteReader.js'; | |||
| import { HypERC20Deployer } from './deploy.js'; | |||
| import { TokenRouterConfig, TokenRouterConfigSchema } from './schemas.js'; | |||
|
|
|||
| ``; | |||
| * | ||
| * @returns Object with deployedHook address, and update Transactions | ||
| */ | ||
| public async deployOrUpdateHook( |
There was a problem hiding this comment.
Nit, public keyword is unnecessary
| this.multiProvider, | ||
| { | ||
| chain: this.args.chain, | ||
| config: actualConfig.hook as HookConfig, |
There was a problem hiding this comment.
Can the casts here and below be avoided?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a multi-part PR.
This adds
createHookUpdateTxs()toWarpModule.update()such that it updates a warp route without a hook, and one with an existing hook.Related issues
Backward compatibility
Yes
Testing
Unit Tests