Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Huy,
I've committed three changes to my fork of bashmarks, all related to how it operates in the global interactive shell environment:
check_help
andexit_message
are particularly unpleasant. I have prefixed private functions with_bashmarks_
; public functions (called by external programs like complete/compctl) withbashmarks_
; and left user-interactive functions as they are.kill SIGINT
, and also implemented each interactive command's behaviour under the abbreviated function name. I think it would be neater to abstract out the implementation, and thus avoid usingkill
too.Let me know what you think, or feel free to apply any or all of the above. Thanks for the great utility, by the way! :-)