Create transfer framework #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
…b.com/hpi-sam/digital-fuesim-manv into feature/891-create-transfer-framework
lukasrad02
reviewed
May 2, 2023
...aviors/transfer-vehicles/simulated-region-overview-behavior-transfer-vehicles.component.html
Outdated
Show resolved
Hide resolved
...aviors/transfer-vehicles/simulated-region-overview-behavior-transfer-vehicles.component.html
Outdated
Show resolved
Hide resolved
...aviors/transfer-vehicles/simulated-region-overview-behavior-transfer-vehicles.component.html
Outdated
Show resolved
Hide resolved
...aviors/transfer-vehicles/simulated-region-overview-behavior-transfer-vehicles.component.html
Outdated
Show resolved
Hide resolved
lukasrad02
reviewed
May 3, 2023
|
During testing, I've noticed that requests handled by the answer request behavior that could not be fulfilled do not cause an internal request for resources any more. Therefore, a staging area won't notify the trainees if there aren't enough vehicles left. Could you please make the answer requests behavior react on the |
lukasrad02
reviewed
May 3, 2023
.../state-migrations/29-remove-transfer-vehicles-activity-and-change-answer-request-behavior.ts
Outdated
Show resolved
Hide resolved
lukasrad02
reviewed
May 3, 2023
.../state-migrations/29-remove-transfer-vehicles-activity-and-change-answer-request-behavior.ts
Show resolved
Hide resolved
|
Looks good! Please add some new test scenarios and I will be fine with this PR! |
|
I changed a validator for an event id because I don't want to use a real uuid for them (they dont use it and changing stuff with randomness always deletes our action history so I do not like it) |
lukasrad02
approved these changes
May 4, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please make sure to fulfil the following conditions before marking this PR ready for review: