Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops.SimpleJumpCorrect: Flag detector invalid if too many jumps. #798

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Bai-Chiang
Copy link
Collaborator

Add input option njump_limit. If there are more than njump_limit jumps in one detector data, then flag the detector and time stream as invalid.

Do we need to flag the detector ob._detflags[name] = self.det_mask or just flag the entire time stream view?

Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A definite improvement.

@Bai-Chiang
Copy link
Collaborator Author

Do we need to flag the detector ob._detflags[name] = self.det_mask or just flag the entire time stream view? What if view is not None, and calculating slice of data, do we still flag entire detector?

@keskitalo
Copy link
Member

Actually, instead of ob._detflags[name] = self.det_mask it would be prudent to use ob._detflags[name] |= self.det_mask to avoid nulling any other detector flag bits.

As for flagging the detector even if the view is not None it seems like the safe approach. If you are finding a ton of jumps, something must be going on with the detector.

Add input option `njump_limit`. If there are more than `njump_limit`
jumps in one detector data, then flag the detector and time stream as invalid.
@Bai-Chiang Bai-Chiang merged commit defcf34 into hpc4cmb:toast3 Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants