Create an all-inclusive example unit test for ground-based data. #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work aims to solve two problems: - Lack of an example unit test for ground telescope data which can be used as a starting point (by removing various things) for future unit tests. - Inconsistent techniques for "scanning from a map" across many unit tests. Basically I have removed ad-hoc code for generating fake sky signal and scanning into timestreams and centralized that in several unit test helper functions.
AERAdler
reviewed
Nov 15, 2024
AERAdler
reviewed
Nov 15, 2024
AERAdler
reviewed
Nov 15, 2024
AERAdler
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work aims to solve two problems:
Lack of an example unit test for ground telescope data which can be used as a starting point (by removing various things) for future unit tests.
Inconsistent techniques for "scanning from a map" across many unit tests. Basically I have removed ad-hoc code for generating fake sky signal and scanning into timestreams and centralized that in several unit test helper functions.