Act atmo calib #754
Merged
Act atmo calib #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit test failures should be fixed now that #755 is merged. |
- Modify the AzimuthIntervals operator to more robustly exclude false "throw" intervals. Instead we first detect the stable pointing periods and then find the exact turnaround sample between those (and raise an exception if there is more than one). This does mean that beginning of the first throw and the end of the last throw are truncated to the stable scan boundary. - In the mapmaker, keep the noise weighted map if `keep_final_products` is True. - In the mapmaker, if the binner is configured to compute and save full detector pointing, use that option when initially computing the pixel distribution. This avoids computing the pointing twice. - When scanning from a map in the template solver, if we already have full detector pointing, then run that over all detectors. - Fix typo in mapmaker from recent refactor.
tskisner
approved these changes
May 10, 2024
|
Thanks for the fixes, everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACT calibration exercise hasn't converged yet but the branch is at risk of going stale.