Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapper frontend login + remove temp auth from React frontend #1903

Open
wants to merge 23 commits into
base: development
Choose a base branch
from
Open

Mapper frontend login + remove temp auth from React frontend #1903

wants to merge 23 commits into from

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works:
Mapper Frontend

  • OSM and Temp login add to mapper frontend
  • Remove Temp login from react frontend
  • Change hot-header component with custom header component with drawer

React Frontend

  • Replace Legend Toggle to map control component
  • Add button named START MAPPING to link react frontend to mapper frontend

Screenshots

image
image
image
image

@NSUWAL123
feat(osm-logo): logo add to mapper
8255386
@NSUWAL123
feat(login): login store add
d713017
@NSUWAL123
fix(layer-switcher): close layer-switcher by default
d30f710
@NSUWAL123
feat(login): login dialog popup add
3bed043
@NSUWAL123
fix(login): util functions add for login
56d4097
@NSUWAL123
fix(login): store current path on localStorage
3696b8d
@NSUWAL123
fix(osmAuth): if user request redirection to mapper frontend then tre…
4bf6246 
…at as external url
@NSUWAL123
feat(logo): hot logo add
65bfd84
@NSUWAL123
fix(header): header component ui slice
e89fdfc
@NSUWAL123
feat(login): toggle modal state add
53cd4aa
@NSUWAL123
fix(layout): replace hot-header with custom header component
9684def
@NSUWAL123
fix(login): replace modalOpen state on parent with stores
75b0822
@NSUWAL123
fix(+layout): barlow font add to root
1fcceed
@NSUWAL123
feat(header): display username and profile image if user logged in
ad4a557
@NSUWAL123
fix(login): signOut add
ac1005c
@NSUWAL123
feat(drawerItems): drawer menu items add
dc67fbc
@NSUWAL123
feat(header): drawer comp add, signout func add
7627afd
@NSUWAL123
fix(layerSwitchMenu): width & height fix
e627880
@NSUWAL123
fix(mapLegends): fix(mapLegends): show map legend in dropdown
4f6c478
@NSUWAL123
fix(mapControlComponent): add mapLegend to mapControlComponent
63e7f3c
@NSUWAL123
fix(projectDetailsV2): remove showing map legend on accordion, btn li…
e426058 
…nking to mapper frontend add
@NSUWAL123
remove(login): remove temporary login from react frontend
0e67d49
@NSUWAL123
Merge branch 'development' of github.com:hotosm/fmtm into feat/mapper…
1fb76e7 
…-login
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code labels Nov 21, 2024
@NSUWAL123
Copy link
Contributor Author

Oh, the frontend test is failing as we had used a temp login for the playwright test. Now what shall be the alternative?

Creating an OSM account to conduct the e2e test? Would that be feasible?

spwoodcock
spwoodcock approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

The only thing missing is the cookie refresh behaviour. On first load the refresh endpoint should be called to attempt cookie refresh (and extend it's expiry). The react frontend does this.

Perhaps it can be a follow up PR, as this is great to merge 😄

@spwoodcock
Copy link
Member

Oh, the frontend test is failing as we had used a temp login for the playwright test. Now what shall be the alternative?

Creating an OSM account to conduct the e2e test? Would that be feasible?

Also good point!

I will hold off from merging and look at playwright options for login 👍

Could you look at the refresh action?

@NSUWAL123
Copy link
Contributor Author

Sure!

@NSUWAL123
Copy link
Contributor Author

@spwoodcock the /refresh endpoint called on the first load on mapper frontend has already been implemented by you.
You were mentioning this right? or I am confused.
image

@spwoodcock
Copy link
Member

Yes that's the one!
I must have forgot 😅
Looks like we are set then!
(I'll just fix up the playwright stuff tomorrow then merge)

@spwoodcock spwoodcock changed the title Feat/mapper login Mapper frontend login + remove temp auth from React frontend Nov 22, 2024
@spwoodcock spwoodcock mentioned this pull request Nov 22, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSUWAL123 @spwoodcock